Closed yonas closed 6 years ago
For some reason, the removal of dugite
wasn't applied from atom3.diff
, although the removal of nsfw
worked:
--- a/node_modules/github/package.json 2017-12-13 21:03:46.089828000 +0400
+++ b/node_modules/github/package.json 2017-12-13 21:10:17.926552000 +0400
@ -134,7 +134,6 @@
"compare-sets": "^1.0.1",
"core-decorators": "^0.19.0",
"diff": "3.2.0",
- "dugite": "1.49.0",
"etch": "^0.12.4",
"event-kit": "^2.3.0",
"fs-extra": "^2.1.2",
After manually fixing node_modules/github/package.json
, I get this error:
Installing modules ✓
Transpiling Babel paths in /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app
Transpiling CoffeeScript paths in /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app
Transpiling CSON paths in /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app
Transpiling PEG.js paths in /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app
Generating module cache for /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app
Generating pre-built less cache in /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app/less-compile-cache
Generating metadata for /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app/package.json
Generating API docs at /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/docs/output/atom-api.json
Skipping symbol dumping because minidump is not supported on Windows
Running electron-packager on /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/out/app with app name "atom"
Downloading electron-v1.6.15-freebsd-x64.zip
Error: GET https://github.com/electron/electron/releases/download/v1.6.15/electron-v1.6.15-freebsd-x64.zip returned 404
/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/lib/package-application.js:141
throw new Error(err)
^
Error: Error: Failed to find Electron v1.6.15 for freebsd-x64 at https://github.com/electron/electron/releases/download/v1.6.15/electron-v1.6.15-freebsd-x64.zip
at electronPackager (/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/lib/package-application.js:141:15)
at /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/electron-packager/index.js:212:23
at end (/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/run-series/index.js:8:15)
at done (/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/run-series/index.js:11:10)
at each (/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/run-series/index.js:16:43)
at /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/electron-packager/index.js:115:25
at /usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/electron-download/index.js:67:20
at done (/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/nugget/index.js:58:9)
at Request.<anonymous> (/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/nugget/index.js:170:58)
at emitOne (events.js:115:13)
at Request.emit (events.js:210:7)
at Request.onRequestResponse (/usr/home/yonas/git/Electron-VSCode-Atom-For-FreeBSD-master/atom/atom/script/node_modules/request/request.js:1068:10)
at emitOne (events.js:115:13)
at ClientRequest.emit (events.js:210:7)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:549:21)
at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)
at TLSSocket.socketOnData (_http_client.js:438:20)
at emitOne (events.js:115:13)
at TLSSocket.emit (events.js:210:7)
at addChunk (_stream_readable.js:263:12)
at readableAddChunk (_stream_readable.js:250:11)
at TLSSocket.Readable.push (_stream_readable.js:208:10)
at TLSWrap.onread (net.js:597:20)
If we can get electron-packager
to download electron-v1.6.15-freebsd-x64.zip
from your repository, I think that would fix it.
I think when patching from atom3.diff
there was some error and rest of the commands from build_atom.sh
was not executed. build_atom.sh
copies electron-v1.6.15-freebsd-x64.zip
locally so that electron-packager
doesn't try to download and fail.
Thanks, that was the issue :)
Using your Atom package works for me, but I get some errors when building it: