prashantchhabra89 / Alternate-Power-Source-Property-Mapper

A web application that puts the power into people's hands for finding sites for sustainable electricity generation.
http://power-planner.appspot.com/
Apache License 2.0
0 stars 1 forks source link

Right click bubble #66

Closed charliegdev closed 9 years ago

charliegdev commented 9 years ago

I was thinking about factoring my code out of init(), but I didn't end up do it for 2 reasons:

1, I think it's logical for them to stay in init(), because nowhere else seems more logically appropriate to set up bubbles and markers. Since map is set up in init(), I think markers should also be set up in init(); bubbles just naturally have to follow markers, because they are essentially part of markers' functionality.

2, It seems my code takes up most places in init(); but most of them are comments. I literally have more comments than code. But if you only count the code (I did), it's actually not that much. Everything about markers and bubbles takes a bit less than 50% of the total amount of code in init(), which is acceptable to me.

If you guys still think factoring out these code out of init() is necessary, I'll do it in MileStone 3.

maxentropic commented 9 years ago

Good job!