prashantgupta24 / automatic-mouse-mover

a minimalistic go library/app to keep your mac active and alive
MIT License
288 stars 33 forks source link

updated dependency for M1 support #37

Closed cnpog closed 1 month ago

cnpog commented 1 year ago
prashantgupta24 commented 1 year ago

Thanks for the PR! Will take a look asap

cnpog commented 1 year ago

thanks for looking at it, I guess the version needs to be 1.18 at least if I understand that pipeline error correctly

prashantgupta24 commented 1 year ago

Will probably need to edit the workflow file which mentions 1.17

prashantgupta24 commented 1 year ago

Hmm, seems to be some issues with the new robotgo lib?

cnpog commented 1 year ago

I cannot replicate this on my machine, do you know how?

prashantgupta24 commented 1 year ago

no :(

Resousse commented 12 months ago

Better go directly with robotGo v1.0.0 which is in RC1(https://github.com/go-vgo/robotgo/releases/tag/v1.0.0-rc1), which seems to bring not retro-compatible change

Resousse commented 10 months ago

this PR can be closed I presume

longgiangp commented 10 months ago

Newest release still uses Rosetta 2 on my M1

Resousse commented 10 months ago

Newest release still uses Rosetta 2 on my M1

I think it's more a matter of compilation because on my side (compiled from source), I have it running as Apple (not Intel)

image
prashantgupta24 commented 10 months ago

Should I add something to the build to build one for Apple macs?

Resousse commented 10 months ago

may be it depends on the system you used to compile, because I didn't add anything, to make "Apple" appear :/

prashantgupta24 commented 10 months ago

@Resousse how did you get to the view where it says Apple ?

Resousse commented 10 months ago

Activity monitor > processes

prashantgupta24 commented 10 months ago

Let me compile it with my m1 and add it to the release. Right now the one I have added was compiled on my x86

longgiangp commented 10 months ago

Should I add something to the build to build one for Apple macs?

Setting Architecture variables should work. I haven't tried yet.

   GOOS=darwin
   BINARY_NAME=amm_universal

   build:
       mkdir -p -v ./bin/amm.app/Contents/Resources
       mkdir -p -v ./bin/amm.app/Contents/MacOS
       cp ./appInfo/*.plist ./bin/amm.app/Contents/Info.plist
       cp ./appInfo/*.icns ./bin/amm.app/Contents/Resources/icon.icns
       GOARCH=amd64 go build -o ./bin/amm.app/Contents/MacOS/amm_amd64 cmd/main.go
       GOARCH=arm64 go build -o ./bin/amm.app/Contents/MacOS/amm_arm64 cmd/main.go
       lipo -create -output $(BINARY_NAME) amm_amd64 amm_arm64
Resousse commented 10 months ago

When you compiled it it goes with rosetta/intel?

prashantgupta24 commented 10 months ago

When you compiled it it goes with rosetta/intel?

Yep. I see intel instead of Apple in Activity monitor > processes

Resousse commented 10 months ago

on my side, I do not find how to compile an "Intel" version :) My go version is : go1.21.3 darwin/arm64 Same on your side?

Finally I'm able to generate an intel version : CGO_ENABLED=1 GOARCH=amd64 make

JokerQyou commented 4 days ago

Will there be a pre-built ARM64 variant in release section?