prashants / webzash

Easy to use web based double entry accounting software in PHP - MySQL under MIT License
http://webzash.org
Other
208 stars 109 forks source link

remember last account #109

Closed ghost closed 6 years ago

ghost commented 6 years ago

remember last account

ghost commented 6 years ago

I stopped tracking the sqlite db, that was a problem!

It still needs something like migrate scripts so people can upgrade, it doesn't take care of that.

What it takes care of is stopping tracking a file that has personal data. what a blunder.

ghost commented 6 years ago

this[manual sqlite modification instruction] no longer needed with later commits

XXthis to upgrade sqlite db w/o migrate like scripts: ALTER TABLE wzusers ADD COLUMN active_account INTEGER NOT NULL DEFAULT (0);

ghost commented 6 years ago

I didn't test the auto create column commit, but it looks like it would work - so people can just pull..

Though I was just thinking. the sqlite files, people will have to preserve those one last time. a git pull will either delete it or rename it to the template/original sqlite db.They would have had to preserve it before because it was tracked. So this isn't worse, but also not an improvement until... the pull after this one.

prashants commented 6 years ago

Since this patch modifies the data structures and a proper update mechanism needs to be in place for it I will keep this pull request open for now and will include it in next update.

ghost commented 6 years ago

Test and accept please. I am pretty sure I tested everything. It should update databases fine