search

prashantsaini1 / android-titanium-imagecropper

Image cropping for Android/Titanium
Apache License 2.0
25 stars 5 forks source link

Problem when using no action bar theme across the app #3

Closed qasim90 closed 6 years ago

qasim90 commented 6 years ago

When the action bar is hidden using custom theme from tiapp.xml the crop window won't show the action bar (and hence the crop button) even if you specify an action bar theme from styles in the crop method options. Following is how I am using themes:

App theme in tiapp.xml: Theme.NoActionBar (Action bar hidden) theme in crop method: Theme.BlueActionBar (Action bar exists) Result: Action bar (and so the top actions) not displayed in the crop window.

App theme in tiapp.xml: Theme.BlueActionBar (Action bar hidden) Result: Action bar (and so the top actions) are displayed in the crop window.

I am using Titanium SDK 7.0.2.GA.

prashantsaini1 commented 6 years ago

Can you try by renaming your themes like NoActionBar and BlueActionBar as I guess its the period (.) in your theme name causing this issue?

emptybox commented 6 years ago

Just trying to find out if this issue has been resolved? Would love to use the module but no way around the 'crop' button missing from no action bar showing.

qasim90 commented 6 years ago

@emptybox you can use an action bar enabled theme specifically for the crop window with the theme property. I ended up enabling the action bar for whole app from tiapp and hiding it on windows where I needed.

emptybox commented 6 years ago

Thanks! I was hoping to do the opposite and enable the action bar on demand but I'll try this.

On Sun, Aug 26, 2018 at 21:43 qasim90 notifications@github.com wrote:

@emptybox https://github.com/emptybox you can use an action bar enabled theme specifically for the crop window with the theme property. I ended up enabling the action bar for whole app from tiapp and hiding it on windows where I needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prashantsaini1/android-titanium-imagecropper/issues/3#issuecomment-416112662, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE5ocvMYw6MloW4P5Do6rYfL7gTESFzks5uU3jjgaJpZM4TALcK .

-- Sent from Gmail Mobile

prashantsaini1 commented 6 years ago

@emptybox you can set any action-bar enabled theme to the theme attribute in the module code. please refer the docs for more details. If no theme is provided, then only the app-wide theme will be used.