Few improvements - Githubissues

prashishh / nepDigit

Convert Nepali Numbers from Digits to Nepali Language.

5 stars 7 forks source link

Closed amitness closed 7 years ago

amitness commented 7 years ago

Existing unicodeToNumbers() function didnot work for number with leading 0. Example: 0123 gave 83 because it used eval to convert string to integer. Fixed that.
Added test cases so that we can refactor or add new features without breaking existing code.

prashishh commented 7 years ago

Thanks for the PR @studenton. I'll review it shortly.

amitness commented 7 years ago

@prashishh Sure.