search

prashnts / pybloomfiltermmap3

Fast Python Bloom Filter using Mmap
https://github.com/prashnts/pybloomfiltermmap3
MIT License
130 stars 24 forks source link

Add BitCount and calculate approximate size. #40

Closed xyb closed 4 years ago

prashnts commented 4 years ago

Hey! Thank you for this, I'll check it out next week or so. (currently off my computers).

PS: the citation looks helpful, thanks!

prashnts commented 4 years ago

I refactored the code a bit to extract the magic in a new object property. @xyb Does this make sense?

xyb commented 4 years ago

@prashnts Cool.

I'm glad you changed bit_count to a property. I didn't do this because I was a little concerned that this operation would be too time-consuming, although I haven't specifically tested its performance.