Closed GoogleCodeExporter closed 9 years ago
[deleted comment]
[deleted comment]
[deleted comment]
Yeah, my toast here wasn't quite accurate. I think what's happening is: the
location service is looking to get a location using the cell network or wifi
connection, currently (you can also set it to get it from the phone's GPS). If
you have no network connection, the location is returned as null.
I think we're going to want to include the provider for the location service
(wifi or GPS) as a preference and then show the relevant error message
depending which provider we're using. So this is dependent on when we get the
preferences to work properly. :)
I've changed the toast message though to more accurately reflect what is
happening. :)
Original comment by captainfoecking@gmail.com
on 26 Sep 2011 at 4:34
I think the new toast is still a bit misleading. Notice that the location
service still returns null if you disable location by wireless and leave GPS
turned on in an indoor area where there's no GPS signal (you might have to
reboot first to clear the phone's last known location, I'm not sure.) The new
toast then makes it sound like you need a network connection for a location
(which you don't with GPS) and makes it sound like you don't have a network
connection (when your connection might actually be fine and wireless location
is just disabled.)
Original comment by exciting...@gmail.com
on 28 Sep 2011 at 1:37
The best approach might be a simple "Location currently unavailable." message.
Original comment by exciting...@gmail.com
on 28 Sep 2011 at 1:38
Pushed changes that tidy this up a bit. Let me know what you think. But here
is what can be done in addition: add a dialog box with a
confirm-save-if-0-latlong case leaving it up to the user to decide if they want
to save a find with 0,0.
Original comment by captainfoecking@gmail.com
on 30 Sep 2011 at 10:04
[deleted comment]
[deleted comment]
Looks good! :)
I made the confirm to save dialog and put it in a patch for Issue 208.
Original comment by exciting...@gmail.com
on 1 Oct 2011 at 12:50
These issues were fixed indirectly.
Original comment by ram8...@gmail.com
on 25 Nov 2011 at 10:38
Original issue reported on code.google.com by
exciting...@gmail.com
on 24 Sep 2011 at 6:00