Open KumShivam opened 7 years ago
I will take care of:
I will take up another point after the above are completed.
Why is the timeline and Viz so overlapping? Space them out?
This is a big issue in itself so this has been shifted to #41 @digi0ps, @jeremyphilemon @Tanay2112 will be handling this.
I expect @parsoyaarihant to pull off the rest, some of them are pretty trivial. Documenting them for @parsoyaarihant:
Test events timeline, it's not fool-proof yet. The events pipeline works. The problem lies with the API's data. Viz is generating the supposed view. @KumShivam you find specific problems, please open up a new issue.
Tweet Display Card placement: It should open where the Bubble is I think you know this already. Your satellite viz has an excellent popover which follows the user mouse movements on hover. Code to be fixed: https://github.com/prastut/bubble-frontend/blob/master/public/js/app/utils/scattergraph.js#L292-L294
Emojis on hover ka placement dekh lo ek baar. It's appearing way above the line chart. This has already been fixed here: http://prastutkumar.design/idc-work-viz/?work. Scourge the code. Probably will take 5 minutes.
Increase Tweet Card Display Time to 10 seconds Code to fixed: https://github.com/prastut/bubble-frontend/blob/master/public/js/app/utils/scattergraph.js#L324
@all Let's fix Point 1 and 2 from issue #20 is not fully done. Please re-visit it
in the end.
Tweet Display Card placement: It should open where the Bubble is
do we really need the black background when the tweet display card is appearing? can we just do a popup like :
@parsoyaarihant we actually decided that we show how the twitter renders the text:
Much more intuitive.
Check if @harwee is parsing twitter ID in the data. You just need to call Twitter's embed code with that ID and voila you will have the same thing rendered without doing anything yourself.
@parsoyaarihant he is: https://github.com/prastut/bubble-frontend/blob/master/docs/API.MD#get-scatter-data
You can see the tweet_id
key in the sample response.
Okay
Emojis on hover ka placement dekh lo ek baar. It's appearing way above the line chart.
Which emojis are you referring to? Can you give a screenshot?
Should this be closed?
Nope
Point 1 and 2 from issue #20 is not fully done. Please re-visit it.
This is still left I guess. @KumShivam
The viz needs a lot of optimization. Since the link is down, I'm not able to exactly pin-point. But from what I remember: