search

prastut / bubble-frontend

Bubble Social
https://bubble.social/
0 stars 0 forks source link

video-demo-fixed #55

Closed prastut closed 7 years ago

prastut commented 7 years ago

Fixed video-demo-layout.

prastut commented 7 years ago

@digi0ps it was a bad idea to move the yPos code inside the graph files. I needed the yPos handlers outside of the concern of the charts because then we can have flexible charts.

Right now if I wanted to show the charts like I want to render only the line + scatter chart, your code will not work as it is dependent on the context that there has to be text and barchart and then only I can render the line+scatter chart.

Please go through the code to understand what would be an ideal situation.

digi0ps commented 7 years ago

Ahhh am really sorry. That was bad code. I thought that the charts code will only be used for webview. That's nice what you did there.