prataprc / xorfilter

Rust library implementing xor-filters
Apache License 2.0
137 stars 18 forks source link

Use rotate_left from stdlib #4

Closed kirushik closed 4 years ago

kirushik commented 4 years ago

Rust standard library provides built-in methods for rotating u64 left and right (https://doc.rust-lang.org/stable/std/primitive.u64.html#method.rotate_left).

This doesn't yield any noticeable performance difference (despite now being implemented as a compiler intrinsic; at least not for me with 1.42-nightly x64 Linux compiler) — but at least makes code a little bit cleaner and easier to maintain.

kirushik commented 4 years ago

Superseded by #5