search

prateek-chaubey / YTPro

All in one YouTube App with downloader , background player and many more features.
https://prateek-chaubey.github.io/YTPro
MIT License
213 stars 35 forks source link

Update AndroidManifest.xml #41

Closed soulnous closed 1 month ago

drogga commented 1 month ago

@soulnous Nope, wrong, nobody wants it to always run in and be restricted to landscape only on everything, remove the whole screenOrientation line instead, as it's unnecessary. @prateek-chaubey can merge after. ;)

drogga commented 1 month ago

@prateek-chaubey can you please finally merge these PRs, there shouldn't be conflicts I think, let's not keep them open for years (like in some repos), because there's a chance that people will lose interest and start deleting their patches and close their PRs, or at least make someone a collaborator/member or whatever with permission to carry on the project... As of this one in particular: It's probably created with the Allow edits by maintainers option enabled, so you should be easily able to edit it and merge (if the author doesn't want to for some reason) or at least close it, as in its current state it's pointless.

Thank You and I hope that you see this (if you do, please react with an emoji, like 'eyes' for example, so I know I'm not wasting my time in typing in vain) ;)