Added Husky, Lint-Staged and Prettier to the project

nirmalhk7 commented 4 years ago

Signed-off-by: Nirmal Khedkar nirmalhk7@gmail.com

What does this PR do? Fixes #112 .
Any background context you want to provide? Basically, this PR introduces Prettier, Husky and Lint-Staged to the project: every commit made in this project from this PR onwards, if it matches the condition's we've set in package.json, will be stylised automatically. This reduces a lot of time spent in pin-pointing incorrect coding practices.

Although prettier suggests to stick to the default settings for code styling, I'm okay to implement some specific settings if the community demands. Please go through the options prettier provides here.

prateek3255 commented 4 years ago

Can you also add ESLint with autofix on save?

nirmalhk7 commented 4 years ago

I'm aware that eslint --fix will fix any linter warnings, but I'm not aware of any command to fix ESlint warnings on save, that's something that'd need to be set up in your particular code editor (here's a tutorial for VSCode).

Should I simply add eslint --fix?

nirmalhk7 commented 4 years ago

@prateek3255 I understand you must be busy, but I'd like an update on this. Thank you :)

prateek3255 / scrroll-in

Added Husky, Lint-Staged and Prettier to the project #121