search

prateekbh / preact-async-route

Async route component for preact-router
MIT License
138 stars 14 forks source link

Bug/Fixed typescript path prop #22

Closed jahilldev closed 6 years ago

jahilldev commented 6 years ago

Added missing path property to TypeScript interface.

jahilldev commented 6 years ago

@prateekbh @andybons Here it is!

prateekbh commented 6 years ago

@jhdevuk can you bump the version to 2.2.0?

jahilldev commented 6 years ago

@prateekbh All done :)

prateekbh commented 6 years ago

@jhdevuk @andybons PR is failing tests :| and i am somewhat(if not total) noob in TS. can you guys check?

jahilldev commented 6 years ago

@prateekbh @andybons It would seem this is possibly related to: https://github.com/developit/preact-router/issues/280 All that's been added in this PR is an additional property to the interface so this seems like something external/version related.

Alexendoo commented 6 years ago

Yeah that should be fixed now preact-router 2.6.1 is out, you wouldn't need to add the path property either. preact-router provides that but it had to catch up with some upstream type changes in preact