prateekbh / preact-material-components

preact wrapper for "Material Components for the web"
https://material.preactjs.com
MIT License
553 stars 81 forks source link

Demo site is broken in Firefox #1274

Open filipdanic opened 5 years ago

filipdanic commented 5 years ago

I opened https://material.preactjs.com/ in Firefox and… it’s kind of broken. Clicking on the home drawer doesn’t do anything and there is no error in the console.

Opening a link such as https://material.preactjs.com/component/button directly will result in 1/4 of the page having the actual content, and 3/4 of it is blank.

filipdanic commented 5 years ago

I should note that I came here via preact-cli which I used to bootstrap a preact starter with material ui. The drawer component that came with that template doesn’t exhibit the same bug.

cromefire commented 5 years ago

This is known, I found this out will be fixed with the next version, it seems like it's a bug with mdc

cromefire commented 5 years ago

Opening a link such as https://material.preactjs.com/component/button directly will result in 1/4 of the page having the actual content, and 3/4 of it is blank.

I cannot confirm that

filipdanic commented 5 years ago
screen shot 2019-01-30 at 2 44 10 pm

This is what it looks like on my end.

cromefire commented 5 years ago

Oh you mean that, yes that's also known, but I don't know if that is fixed.

cromefire commented 5 years ago

But it's a thing that is rather post 2.0, because it is fixed by the newer components. Until then I would recommend to look at the golden images: https://github.com/prateekbh/preact-material-components/tree/v1.5.5/docs/tests/golden/wide

Or the material docs: https://material.io/develop/web/

Sorry

prateekbh commented 5 years ago

hah nice find! that's an easy fix.. i'll get it right in

cromefire commented 5 years ago

should be fixed

prateekbh commented 5 years ago

how?

cromefire commented 5 years ago

Oh no sorry I thought that problem did also affect the desktop and you released the docs...

prateekbh commented 5 years ago

nah it didnt re-deployed

cswl commented 5 years ago

Is there any update? Its still broken in Firefox

cromefire commented 5 years ago

Once 2.0 is published it will be fixed

DenysVuika commented 5 years ago

I can confirm the problem is still there

cromefire commented 5 years ago

Yes bei assured we know that, I'm using Firefox myself, this will be fixed with 2.0