search

prateekbh / preact-material-components

preact wrapper for "Material Components for the web"
https://material.preactjs.com
MIT License
553 stars 81 forks source link

[Select] Add name prop #1281

Closed cromefire closed 5 years ago

cromefire commented 5 years ago

Fixes #1279

artipost commented 5 years ago

Failed pictures (1): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 494500557, for commit cf7bb95.

cromefire commented 5 years ago

@prateekbh review and merge please

cromefire commented 5 years ago

Well it's a hot fix for 1.x I didn't want to look up all the properties

prateekbh commented 5 years ago

then lets just do it for name right now?

cromefire commented 5 years ago

Sure change it, I'm currently quite busy

prateekbh commented 5 years ago

Will do 🙂

prateekbh commented 5 years ago

fixed

artipost commented 5 years ago

Failed pictures (1): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 495850214, for commit 327ddb5.

cromefire commented 5 years ago

There are some prettier errors somehow (I don't know why, it should be auto fixed)...

Also npm made that babel security updates, can you please synchronize the versions among them again?

prateekbh commented 5 years ago

sure will fix... can you LG for the code till then?

cromefire commented 5 years ago

Everything fine, but I can't approve, because it my PR you have to approve it

cromefire commented 5 years ago

Can you publish please?

prateekbh commented 5 years ago

Will do today

prateekbh commented 5 years ago

done 1.5.7

cromefire commented 5 years ago

https://isitmaintained.com/project/prateekbh/preact-material-components

prateekbh commented 5 years ago

OMG... No 🙈.. we're only two maintainers, it's not our day job.. we try our best to keep stuff stable. I guess we should draw a line here

It'll be extremely difficult for us to get that green 😐

WDYT?

cromefire commented 5 years ago

I think 8 Days is a very good time, I think that should deserve green, but I just found it and wanted to share it

cromefire commented 5 years ago

I guess that's not a really good indication. And we're even better than mwc: https://isitmaintained.com/project/material-components/material-components-web

cromefire commented 5 years ago

If you search around all the bigger projects are slower