Closed kontrollanten closed 5 years ago
I'm not sure that this is the right place, maybe it suited better at mdc, they specify the html
In their docs they're using div
element (which is also wrong, but not aside
), so this shouldn't be aligned with mds? https://github.com/material-components/material-components-web/tree/master/packages/mdc-dialog
Well I guess the dialog doesn't break anything right? The only problem it that you should also create a PR against 2.0
because we already split them off.
ummm doesn't dialog
have its own functionality for showing a modal?
Yes, it have. My bad. Shall we use section
instead?
Hmm I didn't know that dialog had that ability, I thought it's just some made up tag
Why not div with proper aria?
I know mdc web takes care of accessibility so I don't think it's s problem
According to https://github.com/dequelabs/axe-core/blame/develop/lib/commons/aria/index.js#L279 it's not allowed, which gives me problem in my nightwatch-accesibility tests (built upon axe-core).
Hmm then may section of the second best option.
According to https://github.com/dequelabs/axe-core/blame/develop/lib/commons/aria/index.js#L279 an alertdialog should be of element type dialog or section.
Closes #1288