Upgrading drawer - Githubissues

prateekbh / preact-material-components

preact wrapper for "Material Components for the web"

https://material.preactjs.com

MIT License

552 stars 81 forks source link

Closed prateekbh closed 5 years ago

prateekbh commented 5 years ago

Fixes #1251 #1250

PMCSlider

cromefire commented 5 years ago

Nice one

cromefire commented 5 years ago

Is there any way that we can automatically test this? I guess we'll have to look into drag & drop support in cypress.

prateekbh commented 5 years ago

@cromefire yeah we just need to enable this for mousedown/up/move and we'll be able to test it with cypress

prateekbh commented 5 years ago

@cromefire Tests for swipe added

prateekbh commented 5 years ago

ping

cromefire commented 5 years ago

There are still 3 comments left unanswered

cromefire commented 5 years ago

Also since when do we have netlify?

cromefire commented 5 years ago

I think after this there is not that much to do until we can roll the first alpha 🎉

cromefire commented 5 years ago

This does not look correct:

Screenshot

prateekbh commented 5 years ago

yep thats y added a preview deploy from netlify also the navigation links are not really working

prateekbh commented 5 years ago

@cromefire all known corner cases are now covered.

I'll work on some cross browser issues post alpha release

cromefire commented 5 years ago

That looks quite good but let us look at 2 short things:

The drawer is only visible if I touch it
I think we should extract that into it's own class instead using a prop (can do that)

prateekbh commented 5 years ago

Gotcha... Will do in next release