Ripple component - Githubissues

prateekbh / preact-material-components

preact wrapper for "Material Components for the web"

https://material.preactjs.com

MIT License

555 stars 81 forks source link

Closed cromefire closed 5 years ago

cromefire commented 5 years ago

Ripple component that just attaches a ripple to something

cromefire commented 5 years ago

@prateekbh do you know why the component doesn't work? I'm pretty sure I got every thing right

prateekbh commented 5 years ago

how come this PR is not getting a netlify preview

cromefire commented 5 years ago

I don't know, maybe I need to push after it's not WIP

prateekbh commented 5 years ago

I see that the javascript is working fine... i guess styling is a problem:

cromefire commented 5 years ago

That may indeed be the case

cromefire commented 5 years ago

Fixed, review pls

prateekbh commented 5 years ago

the preview doesnt seem to work :/

cromefire commented 5 years ago

That's correct but in the preview a bunch of things do not work (e.g. the switch)

prateekbh commented 5 years ago

WDYM? isnt the switch page working?

cromefire commented 5 years ago

The one for dark mode. You can toggle it, dark mode works, but the switch looks like it's off

prateekbh commented 5 years ago

Off as in?

cromefire commented 5 years ago

This is how it looks to me (FF 68):

cromefire commented 5 years ago

It's some how just missing css rules (and I don't know why, no errors on console, no failed network requests)

prateekbh commented 5 years ago

lol at least it works in chrome... anyways can you just add a dummy test and then we can merge it if this works for you

cromefire commented 5 years ago

lol at least it works in chrome...

It's also working locally for me

prateekbh commented 5 years ago

I'll be able to PR tabs only after 7th Aug, feel free to take it if you want

cromefire commented 5 years ago

Will look at it if I've got some time