Ripple component

[cromefire]

Ripple component that just attaches a ripple to something

[cromefire]

@prateekbh do you know why the component doesn't work? I'm pretty sure I got every thing right

[prateekbh]

how come this PR is not getting a netlify preview

[cromefire]

I don't know, maybe I need to push after it's not WIP

[prateekbh]

I see that the javascript is working fine... i guess styling is a problem:

https://github.com/material-components/material-components-web/tree/master/packages/mdc-ripple#sass-apis

[cromefire]

That may indeed be the case

[cromefire]

Fixed, review pls

[prateekbh]

the preview doesnt seem to work :/

[cromefire]

That's correct but in the preview a bunch of things do not work (e.g. the switch)

[prateekbh]

WDYM? isnt the switch page working?

[cromefire]

The one for dark mode. You can toggle it, dark mode works, but the switch looks like it's off

[prateekbh]

Off as in?

[cromefire]

This is how it looks to me (FF 68):

[cromefire]

It's some how just missing css rules (and I don't know why, no errors on console, no failed network requests)

[prateekbh]

lol at least it works in chrome... anyways can you just add a dummy test and then we can merge it if this works for you

[cromefire]

lol at least it works in chrome...

It's also working locally for me

[prateekbh]

I'll be able to PR tabs only after 7th Aug, feel free to take it if you want

[cromefire]

Will look at it if I've got some time