search

prateekbh / preact-material-components

preact wrapper for "Material Components for the web"
https://material.preactjs.com
MIT License
552 stars 81 forks source link

Upgraded tabs #1331

Closed cromefire closed 4 years ago

cromefire commented 4 years ago

Fixes #1267 and fixes #1268

prateekbh commented 4 years ago

btw we'll need an implementation with swipable tabs.. I can look into it parallely if u want

cromefire commented 4 years ago

Sure

cromefire commented 4 years ago

But aren't they swipeable already?

prateekbh commented 4 years ago

These are just TabBar.. we need to have like full fledged tabs(with content)

cromefire commented 4 years ago

Most things are fixed with just one small bug left (at least from what I've found)

cromefire commented 4 years ago

Okay and a major one. Active tabs are making some problems

prateekbh commented 4 years ago

@cromefire whats remaining in this?

cromefire commented 4 years ago

I was having architectural problems with how to set the active tab.

Setting a Tab active does not work with the state management of mdc and setting it on Tabs makes Problems with the styles on the active Tab. And also time...

prateekbh commented 4 years ago

pushed a change to docs page, works for me

prateekbh commented 4 years ago

including firefox 😛

cromefire commented 4 years ago

The netlify preview is broken somehow, I guess preact-render-to-string has to be added to dev-dependencies in the docs since the cli update

prateekbh commented 4 years ago

i'll take a look

prateekbh commented 4 years ago

deploy preview is fixed

cromefire commented 4 years ago

Looks quite quite good. I'll fix a few small thing and then it's good to go

prateekbh commented 4 years ago

@cromefire i plan to upgrade all deps after this pr and publish an alpha. WDYT?

cromefire commented 4 years ago

Seems fine

prateekbh commented 4 years ago

Hi! I am speaking about Preact Ecosystem changes on http://reactindia.io. Would like to publish an alpha before that WDYT?

cromefire commented 4 years ago

I'm fine with that just keep in mind that you still wanted to implement the tab content things

prateekbh commented 4 years ago

It kinda tough, i'll try doing it in beta may be

prateekbh commented 4 years ago

i just wanted to use nuka carousel but isnt straight forward

prateekbh commented 4 years ago

so the alpha wont have the swipable tabs for now

cromefire commented 4 years ago

Do we even have non swipable tabs right now?

cromefire commented 4 years ago

Also so I would like to keep this in alpha until we have all the features

cromefire commented 4 years ago

(but of course there can be multiple alpha versions)

prateekbh commented 4 years ago

Yes totally aligned, all I am aiming for is alpha1

cromefire commented 4 years ago

Well then go for it

prateekbh commented 4 years ago

wopuld like to get this PR in for alpha 1

cromefire commented 4 years ago

Nobody is stopping you

prateekbh commented 4 years ago

Lol the WIP was blocking me 😛

cromefire commented 4 years ago

That's the purpose of it

prateekbh commented 4 years ago

Thanks for working on this.. will check the tests and probably merge it