search

prateekbh / preact-material-components

preact wrapper for "Material Components for the web"
https://material.preactjs.com
MIT License
555 stars 81 forks source link

support preact X #1334

Closed prateekbh closed 5 years ago

prateekbh commented 5 years ago

Fixes #1301

artipost commented 5 years ago

Failed pictures (25): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577554944, for commit 9d32a2f.

cromefire commented 5 years ago

Was it intended to be against master?

artipost commented 5 years ago

Failed pictures (25): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577558618, for commit c1f70ef.

prateekbh commented 5 years ago

yes, this is Preact X support for 1.x

artipost commented 5 years ago

Failed pictures (25): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577561065, for commit 961297f.

artipost commented 5 years ago

Failed pictures (25): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577562877, for commit 802354b.

prateekbh commented 5 years ago

hmmm supporting both at once seems messy, WDYT about 2.0 working with X and 1.X works with < X

cromefire commented 5 years ago

Support for both is quite easy: If there is props use that else use attributes

artipost commented 5 years ago

Failed pictures (25): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577576309, for commit abf5e05.

artipost commented 5 years ago

Failed pictures (25): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577580232, for commit 979ce1b.

artipost commented 5 years ago

Failed pictures (24): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577586818, for commit 8c80489.

artipost commented 5 years ago

Failed pictures (25): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577591433, for commit dcd4df2.

artipost commented 5 years ago

Failed pictures (24): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577594052, for commit b71355e.

artipost commented 5 years ago

Failed pictures (1): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 577596174, for commit 56f6a0c.