search

prateekbh / preact-material-components

preact wrapper for "Material Components for the web"
https://material.preactjs.com
MIT License
552 stars 81 forks source link

PreactX support #1335

Closed prateekbh closed 3 years ago

prateekbh commented 4 years ago
prateekbh commented 4 years ago

@cromefire when ever i try to build docs I am getting the following error

https://pastebin.com/4aWwCV7n

I remember you fixed this earlier, any ideas?

cromefire commented 4 years ago

Yes I wrote a custom resolver for sass-loader:

https://github.com/prateekbh/preact-material-components/blob/762edebc0ab1f340b693bed6cba98ff29daa9297/packages/docs/preact.config.js#L11-L25

https://github.com/prateekbh/preact-material-components/blob/762edebc0ab1f340b693bed6cba98ff29daa9297/packages/base/build/index.ts#L1-L124

prateekbh commented 4 years ago

https://github.com/prateekbh/preact-material-components/issues/1336 - noted failing tests here

cromefire commented 4 years ago

Why did you do the dummy commit?

prateekbh commented 4 years ago

should've just restarted the tests 🤦🏻‍♂️