search

prateekbh / preact-material-components

preact wrapper for "Material Components for the web"
https://material.preactjs.com
MIT License
552 stars 81 forks source link

List.ItemMetaText for non-icon ItemMeta #1338

Closed fopina closed 4 years ago

fopina commented 4 years ago

As discussed in #1337

fopina commented 4 years ago

will do @prateekbh but do you agree with the change as is? or do you prefer some other approach?

prateekbh commented 4 years ago

The PR looks good, just a small change

artipost commented 4 years ago

Failed pictures (2): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 598173755, for commit d3f8ad4.

fopina commented 4 years ago

docs updated, but no clue on padded option (added reply to your comment)

prateekbh commented 4 years ago

@fopina this looks good please add the failed pictures here in your repo: https://github.com/prateekbh/preact-material-components/tree/master/docs/tests/golden/wide

artipost commented 4 years ago

Failed pictures (1): failed-pictures.zip

:postbox: Posted by artipost.io, through Travis build 598558074, for commit e272410.

fopina commented 4 years ago

hope it looks good now :+1: