search

prateekiiest / titanic_survival_exploration

Udacity Machine Learning Nano degree Program Project Predicting Passenger Survival
MIT License
21 stars 35 forks source link

Added Embarked_Vs_Survived Plot And Engineered Features #21

Closed shreyas-kowshik closed 6 years ago

shreyas-kowshik commented 6 years ago

SHORT DESCRIPTION

Added the Embarked_Vs_Survived plots for visualizations.

TESTING

Run the python code and get the required plot.

shreyas-kowshik commented 6 years ago

@prateekiiest please review

shreyas-kowshik commented 6 years ago

Please review @prateekiiest

prateekiiest commented 6 years ago

there some issues with codacy and codeclimate, please fix them

prateekiiest commented 6 years ago

Tests are failing.

shreyas-kowshik commented 6 years ago

Checked and reviewed the engineered_features.py file for errors and updated the code accordingly @prateekiiest .

prateekiiest commented 6 years ago

there are still some failing issues @shreyas-kowshik

shreyas-kowshik commented 6 years ago

can you please elaborate?The code compiles fine on my side and produces the proper output.Is there an issue with the code quality?If yes then in one implementation I cannot reduce the nesting and the logic for it is quite simple,so complexity is not much logically speaking.The quality has issues there only mainly. @prateekiiest

prateekiiest commented 6 years ago

its actually the code style that codacy/ codeclimate hints at.

If you use too much loops it will make it worse. Instead of loops you should go for some thing like np.iterate or other that are vectorized

prateekiiest commented 6 years ago

still failing

prateekiiest commented 6 years ago

would you wanna work on this ?

prateekiiest commented 6 years ago

I am closing this as of now

prateekiiest commented 6 years ago

I will work on your code and will merge it later :smile: