prateekiiest / titanic_survival_exploration

Udacity Machine Learning Nano degree Program Project Predicting Passenger Survival
MIT License
21 stars 35 forks source link

Add Issue and Pull Request Template #5

Closed prateekiiest closed 7 years ago

prateekiiest commented 7 years ago

Search existing such templates here

schalkneethling commented 7 years ago

@TremaineNeethling this looks like something you can pick up

schalkneethling commented 7 years ago

@prateekiiest do you have something in mind for the template?

prateekiiest commented 7 years ago

Some thing like this

Issue

PR

schalkneethling commented 7 years ago

Myself and @TremaineNeethling talked about this and here are some thoughts:

This is auto generate by Github when a new issue is created so, I reckon we can leave this

Something like, “Please provide a short, clear description of the problem”

“Please describe the problem you encountered, and steps to reproduce”

This is not always known at issue creation time so, we can either reword or, leave this off. If reword, it can perhaps read something like: “If known, which file(s) needs to be changed?”

schalkneethling commented 7 years ago

I wonder if the PR requirements should be part off the README/CONTRIBUTING files? I often feel like there could be two sections to a contributing/get involved section.

1) Assume prior knowledge 2) Assume no prior knowledge

Have 2 be first and allow other users to skip over the basics. Thoughts?

prateekiiest commented 7 years ago

I feel that PR requirements be included in the contributing.md section.

TremaineNeethling commented 7 years ago

@prateekiiest Here is my pull request https://github.com/prateekiiest/titanic_survival_exploration/pull/6