search

prathamVaidya / supercode-tinymce-plugin

Opensource and Powerful Source Code editor for TinyMCE. It is the only tinyMCE plugin that allows TinyMCE to work as a Markdown Editor.
https://supercode.prathamvaidya.in
GNU General Public License v3.0
12 stars 4 forks source link

Persistent theme selector #6

Open robcarey opened 5 months ago

robcarey commented 5 months ago

Added theme selector, persistence, and supporting styles.

prathamVaidya commented 5 months ago

Thanks for finding the time to contribute but I am not sure if user theme selection for ace editor is a feature that everyone will need.

I think from a UI/UX perspective its better to keep the theme of ace editor to match the theme of tinyMCE editor. In case theme selection is a requirement then developers can create a general option in there app settings to ask the user's theme choice. Then this selected theme choice should be applied to both TinyMCE and AceEditor.

I'll keep the PR open in case someone wants this; we might add it officially in the future. Even when we'll add it, we'll need to make this feature optional and fully configurable, including adding it to classic mode and not just the modal dialog view.