prathameshgaikwad / Innings

A cricket scorekeeping and tournament management app
https://innings.vercel.app
1 stars 7 forks source link

Added cricket-theme loading animation #10

Closed siddharthisrani closed 1 month ago

siddharthisrani commented 1 month ago
vercel[bot] commented 1 month ago

@siddharthisrani is attempting to deploy a commit to the prathameshgaikwad's projects Team on Vercel.

A member of the Team first needs to authorize it.

prathameshgaikwad commented 1 month ago

I checked out the loading animation, good work with that!

However, it would be better to use the colors that are defined in the theme. For instance, the black color that you have given to the "Main" component, let it be dictated by the theme. Also the font of the "Loading" text looks out of design. To maintain harmony with the app's original design, you must use the Material UI components. That way you won't have to worry about defining separate colors or fonts in this case.

Also, I personally feel the bat & the ball icon are a bit large, and that they would look better if made smaller.