search

prathimacode-hub / Awesome_Python_Scripts

🚀 Curated collection of Awesome Python Scripts which will make you go wow. Dive into this world of 360+ scripts. Feel free to contribute. Show your support by ✨this repository.
https://prathimacode-hub.github.io/Awesome_Python_Scripts/
Mozilla Public License 2.0
342 stars 254 forks source link

Video Merger #1099

Open ambushneupane opened 1 year ago

ambushneupane commented 1 year ago

Related Issue

  • A python script to Merge Many videos into a single Video

  • [x] Hacktoberfest2021 Participant

  • [x] Contributor

Closes: #1100

Describe the changes you've made

Type of change

What sort of change have you made:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, local variables)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

The script has been tested the script on my local machine for different test cases.

Checklist:

  • [x] My code follows the guidelines of this project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly whereever it was hard to understand.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [x] Any dependent changes have been merged and published in downstream module
welcome[bot] commented 1 year ago

Hello there! 👋 Welcome to the project! 💖 Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

prathimacode-hub commented 1 year ago

First create an issue using issue template, add issue details and get it assigned. Then work on it. And while creating PR, add PR template along with PR details and issue number as a commit message. Follow the contributing guidelines. @ambushneupane

prathimacode-hub commented 1 year ago

Don't work on issue without getting merged. First sort the issue fixings. Use PR template as a commit message along with issue details and issue number in it. @ambushneupane

ambushneupane commented 1 year ago

So what am I supposed to do? Can you provide me the correct procedure for successful PR?

prathimacode-hub commented 1 year ago

Add a PR template provided as a commit message, include issue details and issue number while creating PR. You can refer to this PR as a sample : https://github.com/prathimacode-hub/Awesome_Python_Scripts/pull/1097. You will get better clarity and once you read the contributing guidelines and readme file for PR file format structure. @ambushneupane

ambushneupane commented 1 year ago

Hey Thanks For assigning. Since I have already done the PR, what should I do to get it merged?

prathimacode-hub commented 1 year ago

Add PR template in the commit message above with issue details and issue number to review the PR. @ambushneupane

ambushneupane commented 1 year ago

Hey I have Edited Can you have a look on it?

ambushneupane commented 1 year ago

Hey I have made changes you asked for Can you have a look on it?

ambushneupane commented 1 year ago

Added some Description How to Keep my Project Name as Video Merger?

prathimacode-hub commented 1 year ago

You can rename the file from your forked repository and push the changes again. @ambushneupane