search

prathimacode-hub / DS-ScriptsNook

🎊One Stop Destination to get acquainted with scripts in Data Science. Turn yourself into a pro. Show your support by ✨ this repository.
https://prathimacode-hub.github.io/DS-ScriptsNook/
MIT License
11 stars 25 forks source link

Color Identification using OpenCV #30

Closed vishvarana closed 2 years ago

vishvarana commented 2 years ago

Related Issue Color detection in images using OpenCV

√ DevIncept Participant √ Contributor

Closes: #27

Describe the changes you've made I have added a new project that detects colors in a given image with their proportions using a pie-chart as well as finds those images from a lot which has the mentioned color that we require.

Type of change What sort of change have you made: It is a new feature to this repo.

Bug fix (non-breaking change which fixes an issue)

√ New feature (non-breaking change which adds functionality) Code style update (formatting, local variables) Breaking change (fix or feature that would cause existing functionality to not work as expected) This change requires a documentation update

How Has This Been Tested? Describe how have you verified the changes made I have written code in jupyter notebook to test the code on a particular image and return a pie chart with proportion of its colors. Also I have tested the code by bringing out the images with color we ask for.

Checklist: √My code follows the guidelines of this project. √I have performed a self-review of my own code. √I have commented my code, particularly wherever it was hard to understand. √I have made corresponding changes to the documentation. √My changes generate no new warnings. √I have added test cases that prove my fix is effective or that my feature works.

prathimacode-hub commented 2 years ago

First of all read the README and CONTRIBUTING GUIDELINES of the project. Then you would know the project structure and changes you have to make. @vishvarana

vishvarana commented 2 years ago

Renamed according to snake_case and updated README according to the format.

vishvarana commented 2 years ago

I have to make a different branch right? Rest all is done I guess. Please let me know I am new to this

vishvarana commented 2 years ago

I am opening a new pull request and closing this one because of conflicts

prathimacode-hub commented 2 years ago

But you should never close issues or PR from your end. Not everyone would take it positive. Just letting you know so that you don't do it in future. Instead you could had said it to me to close it. @vishvarana