search

prathimacode-hub / HelloWorld

Add HelloWorld Program in different languages. Do contribute and show your support by starring this repository. Hop in. 💹⭐
https://prathimacode-hub.github.io/HelloWorld/
MIT License
3 stars 6 forks source link

Add files via upload #4

Closed Project-Xenith closed 3 years ago

Project-Xenith commented 3 years ago

Hello World in CPP

prathimacode-hub commented 3 years ago

Thanks for your interest in contribution. You should always make sure to follow the contribution guidelines and README.md file before you create a pull request.

Your repository should be as 'C++' and filename should look like this - HelloWorld_Sparsh.cpp

Program as well didn't follow the guidelines mentioned: This is the task : Output the string "Hello, World!".

To know more about how program should look like, check this format.

Multiples files are not needed in a repository. Only single program file is more than enough. I will review the program using compiler and merge it. Do all the required changes I had mentioned and notify me.

I hope this well help you in making your first pull request. @Project-Xenith

Project-Xenith commented 3 years ago

I have done the needful and have changed the language to objective c please inform me about any new mistakes that i may have made.

On Tue, 4 May 2021 at 14:21, Prathima Kadari @.***> wrote:

Thanks for your interest in contribution. Kindly follow the contribution guidelines and README.md file before you create a pull request. Your repository should be as 'C++' and filename should look like this.

HelloWorld_Sparsh.cpp

Multiples files are not needed in a repository. Only single program file is more than enough. I will review the program and merge it. Do the required changes and notify me. @Project-Xenith https://github.com/Project-Xenith

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prathimacode-hub/HelloWorld/pull/4#issuecomment-831783595, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARG5SRELELLNQIZC7MNNHH3TL6YPJANCNFSM44CIO7PQ .

prathimacode-hub commented 3 years ago

Sorry to say, it needs changes. I don't find any changes done.

Remove all the unncessary files. You just need a repository and file. I guess the program you have inserted is .cpp file and not an objective C file as you stated.

Your repository should be as 'C++' and filename should look like this - HelloWorld_Sparsh.cpp

I have also mentioned the task, Output the string "Hello, World!". It's missing a comma.

These are the only things needed for PR to get merged. Any doubt, feel free to ask. Notify me here when it's done. @Project-Xenith

Project-Xenith commented 3 years ago

done named my pull branch as C++ and file name HelloWorld_Sparsh.cpp

On Tue, 4 May 2021 at 22:19, Prathima Kadari @.***> wrote:

Sorry to say, it needs changes. I don't find any changes done.

Remove all the unncessary files. You just need a repository and file. I guess the program you have inserted is .cpp file and not an objective C file as you stated.

Your repository should be as 'C++' and filename should look like this - HelloWorld_Sparsh.cpp

I have also mentioned the task, Output the string "Hello, World!". It's missing a comma.

These are the only things needed for PR to get merged. Any doubt, feel free to ask. Notify me here when it's done. @Project-Xenith https://github.com/Project-Xenith

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prathimacode-hub/HelloWorld/pull/4#issuecomment-832089129, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARG5SRBHKS3UIOOFDEGCPUDTMAQS7ANCNFSM44CIO7PQ .