prathimacode-hub / MedFlare

βœ”Med Flare is an instant medical aid app to resolve the hassles and address the emergencies at right frame of time to the needy. πŸ™Œ
https://prathimacode-hub.github.io/MedFlare/
GNU General Public License v3.0
16 stars 31 forks source link

Header section with navbar added #15

Closed soujo closed 2 years ago

soujo commented 2 years ago

Related Issue

Closes: #7

Describe the changes you've made

Type of change

What sort of change have you made:

How Has This Been Tested?

I have tested the website locally in my machine and also have consulted to my mentor, she approved my design

Checklist:

Screenshots

Original :

There was no section previously

Updated :

Screenshot (190)

welcome[bot] commented 2 years ago

Hello there! πŸ‘‹ Welcome to the project! πŸ’– Thank you and congrats πŸŽ‰ for opening your first pull request. Please adhere to our Code of Conduct. πŸ™ŒπŸ» We will get back to you as soon as we can. πŸ˜„

Feel free to get in touch with me through social media handles. Hope to see you there!πŸ˜„

prathimacode-hub commented 2 years ago

Kindly add the PR template, along with what is added in PR and issue number you allotted to. you can add so using edit option here in PR message. @soujo

soujo commented 2 years ago

@prathimacode-hub , I have made the changes. Kindly look through it

prathimacode-hub commented 2 years ago

Only change it needs, is merge your code of index.html in existing /Home page/index.html since this has only 3 sections, you can include your header and nav bar there. Images let it be as it is. And style.css. keep it out in main instead of inside Home page. So that work you had done is reflected properly. Let me know, once you do and it's ready to be merged then. @soujo

soujo commented 2 years ago

@prathimacode-hub , the code of header section in already in index.html of Home page folder and I didn't got the point about style.css, could you again clarify that please

prathimacode-hub commented 2 years ago

Can you drop me a message in discord. Discussion would be much better to clear up things. @soujo

welcome[bot] commented 2 years ago

Congrats on merging your first Pull Request! πŸŽ‰ All the best for your amazing open source journey ahead. πŸš€βš‘οΈ