Make the navbar buttons work

prakhartiwari0 commented 2 years ago

[x] Hacktoberfest Participant
[ ] Contributor

Closes: #49

Describe the changes you've made

Assigned ids to the main sections of the website
Gave the href attribute of all the navbar buttons their respective section's id to make that button redirect to that specific section when clicked.

Type of change

What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

I simply clicked each button of the navbar to check if they are redirecting me to the correct sections according to their names or not.

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original	Updated
Screencast from 04-10-22 07:30:27 PM IST.webm	https://user-images.githubusercontent.com/65062036/193840980-9ecb60d7-1c3f-4908-8696-c95940d78acb.mp4

welcome[bot] commented 2 years ago

Hello there! 👋 Welcome to the project! 💖 Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

prathimacode-hub commented 2 years ago

Don't directly create a PR without creating an issue and getting it assigned. @prakhartiwari0

prathimacode-hub commented 1 year ago

Can you add the other design changes you had thought of doing it to this PR? @prakhartiwari0

prakhartiwari0 commented 1 year ago

Can you add the other design changes you had thought of doing it to this PR? @prakhartiwari0

If you can tell me what kind of design changes you want, I will add them. But as of now, I don't think the navbar needs many changes. Maybe we could make the underline animation a little faster, and make the navbar's position fixed. But that's not much of an issue.

prathimacode-hub commented 1 year ago

Why have you closed it? @prakhartiwari0

prakhartiwari0 commented 1 year ago

Why have you closed it? @prakhartiwari0

The issue this PR was solving, is actually solved in #66. You said that raising only this issue (that is #49 ) is not legible, so I raised another issue (#57 ) which included more problems related to the home page.

prathimacode-hub / MedFlare