search

prati0100 / git-gui

Tcl/Tk based UI for Git. I am currently acting as the project's maintainer.
161 stars 87 forks source link

Dialog "compressing ... Success" is not closeable with Escape key #17

Closed vn971 closed 4 years ago

vn971 commented 4 years ago

It would be very convenient if this dialog would be closable with just Escape key. 2019 11 29_10:36:20

Additionally and independently, it would be nice for the dialog before that to be closable with Escape, and maybe that Enter would act as "OK".

prati0100 commented 4 years ago

Shouldn't be something too difficult to implement. I'll come up with a patch in a couple days.

prati0100 commented 4 years ago

It would be very convenient if this dialog would be closable with just Escape key.

Patch for this submitted here

Additionally and independently, it would be nice for the dialog before that to be closable with Escape, and maybe that Enter would act as "OK".

Which dialog are you talking about? Is it the one mentioned here? If yes, then this dialog will soon be removed. In fact, I have a half cooked fix for it over at https://github.com/prati0100/git-gui/tree/py/auto-gc which I will finish up soon.

vn971 commented 4 years ago

Yeah, that was the dialog I was talking about. Nice.)

prati0100 commented 4 years ago

Johannes suggested on the mailing list review thread here that Ctrl-W would be a better idea for this than Esc. I agree, but with a slightly different reason here.

If you want to supply a counter-argument, please do so on the mailing list thread (and not on this GitHub thread). Otherwise, I'll go ahead with Ctrl-W.

In case you're not subscribed on the list, reply instructions are given at the bottom of these links.

prati0100 commented 4 years ago

Fixed in https://github.com/prati0100/git-gui/commit/23cbe427c44645a3ab0449919e55bade5eb264bc