search

prati0100 / git-gui

Tcl/Tk based UI for Git. I am currently acting as the project's maintainer.
161 stars 87 forks source link

Add a checkbox to conditionally mask the input text #38

Closed davvid closed 3 years ago

davvid commented 4 years ago

Teach the password text entry field to conditionally mask its input with a checkbox.

The commits in this series were originally submitted to https://github.com/git-cola/git-cola/

Cc: @mboekhold @leaerreal (original authors)

davvid commented 4 years ago

FYI I kept the original authorship, which is why the commits are separate even though they touch the same area.

I figured this was worth doing because I noticed this https://github.com/patthoyts/git-gui/issues/22 and it prompted me to upstream these patches.

cheers

johnjohndoe commented 4 years ago

I appreciate keeping the authorship. FYI, another way to do this is to use git trailers.

prati0100 commented 3 years ago

Hi @davvid,

Thanks for the PR. I usually expect patches to be submitted to the Git mailing list so they can reach a wider set of eyes. You can use GitHub Pull Requests to do that via GitGitGadget. Check the readme for more info.

That said, I'll drop my comments on the pull request here and you can send the new version to the mailing list.

davvid commented 3 years ago

These changes have been submitted to the Git core development list. Closing this PR now.

https://public-inbox.org/git/20201107222039.13900-1-davvid@gmail.com/T/#u