commit message text cursor missing in dark theme for macOS

[lormanlau]

The text cursor when typing in a commit message is not visible while in dark theme. In light theme the cursor blinks and shows normally. I suspect that the cursor is blinking white.

macOS Catalina 10.15.6 git-gui version 0.21.0.72.g46972 git version 2.28.0

Tcl/Tk version 8.6.10

[prati0100]

Seems related to #30. I unfortunately don't have a lot of free time so I can't say for sure when I can get around to looking at it.

[last-partizan]

I don't know about workaround, but proper way to fix this would be to support theming.

Tcl/Tk will have (i hope), proper dark themes by the 8.7 version, and git citool must not hardcode color values.

Gitk does have color configuration on its own, and with some effort i can get it to look like this:

But git citool just uses plain hardcoded color values, so it looks horrible when themed.

@prati0100 i can try to make things just little better, how do i make merge requests? I see this project uses maillist instead of gitlab tools, so i just make patch and send it to maillist?

[prati0100]

Yes, you can make a patch and send it to git@vger.kernel.org. Or if you prefer to use GitHub pull requests, you can use GitGitGadget. See the readme for more info.

[last-partizan]

@lormanlau

https://github.com/last-partizan/git-gui/tree/dark-colors

Please check if this branch fixed bug for you.

[prati0100]

Should be fixed with https://github.com/prati0100/git-gui/commit/01121d6132135e62d4bf7c2e67e749ae3037d0ba. If you still see the issue please feel free to reopen.