prati0100 / git-gui

Tcl/Tk based UI for Git. I am currently acting as the project's maintainer.
160 stars 87 forks source link

git-gui crash under macos 13 beta #78

Closed surjikal closed 2 years ago

surjikal commented 2 years ago

git gui installed via brew install --HEAD git-gui. Looks like a tcl-tk problem rather than git-gui, but figured I'd open this up since it does prevent me from using this glorious tool.

2022-06-20 20:37:59.055 wish[46007:1247485] -[__NSCFString needsSheetAnimation]: unrecognized selector sent to instance 0x600002a65440
2022-06-20 20:37:59.057 wish[46007:1247485] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFString needsSheetAnimation]: unrecognized selector sent to instance 0x600002a65440'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007ff8186eec9b __exceptionPreprocess + 242
    1   libobjc.A.dylib                     0x00007ff8182d4135 objc_exception_throw + 48
    2   CoreFoundation                      0x00007ff81878341b -[NSObject(NSObject) __retain_OA] + 0
    3   CoreFoundation                      0x00007ff8186597fb ___forwarding___ + 1324
    4   CoreFoundation                      0x00007ff818659238 _CF_forwarding_prep_0 + 120
    5   AppKit                              0x00007ff81c25f0cf -[NSWindow _reallyDoOrderWindowAboveOrBelow:] + 1618
    6   AppKit                              0x00007ff81c25fc42 -[NSWindow _reallyDoOrderWindow:] + 99
    7   AppKit                              0x00007ff81c25feae -[NSWindow _doOrderWindow:] + 285
    8   AppKit                              0x00007ff81ba46c34 -[NSWindow makeKeyAndOrderFront:] + 47
    9   libtk8.6.dylib                      0x000000010feaa760 XMapWindow + 346
    10  libtk8.6.dylib                      0x000000010feada1f TkWmMapWindow + 285
    11  libtk8.6.dylib                      0x000000010feb3cdb TkpWmSetState + 132
    12  libtk8.6.dylib                      0x000000010feb1e42 Tk_WmObjCmd + 13588
    13  libtcl8.6.dylib                     0x000000010ff524e5 TclNRRunCallbacks + 79
    14  libtcl8.6.dylib                     0x000000010ff53628 TclEvalEx + 1842
    15  libtcl8.6.dylib                     0x000000010ffefbbb Tcl_FSEvalFileEx + 535
    16  libtk8.6.dylib                      0x000000010fe05e71 Tk_MainEx + 1444
    17  wish8.6                             0x000000010fbf3e82 main + 47
    18  dyld                                0x00007ffb333d0105 start + 2325
)
libc++abi: terminating with uncaught exception of type NSException
error: git-gui died of signal 6

Sometimes it decides to fail with other signals, for example 10.

This only happens if I open git-gui within a repository. The "create new repository" popup works fine.

surjikal commented 2 years ago

If I comment out: https://github.com/prati0100/git-gui/blob/fa28da02024ea4858c29b7caec30a18ee2d6f404/git-gui.sh#L727

my beloved git-gui no longer crashes.

surjikal commented 2 years ago

Looks like things work in beta 2!