Closed rishika-singh49 closed 3 years ago
@rishika-singh49 new to git github?
@pratik-choudhari yes sir...
@rishika-singh49 What were you not supposed to do:
What to do now:
i have done some changes please check it out
@rishika-singh49 No No! You have changed the main README inside C/C++ folder, you are not supposed to do that.
But I have already created a file named doubly linked list in which I have placed the code and it's output.
On Fri, Oct 16, 2020, 9:56 PM Pratik Choudhari notifications@github.com wrote:
@rishika-singh49 https://github.com/rishika-singh49 No No! You have changed the main README inside C/C++ folder, you are not supposed to do that.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pratik-choudhari/AlgoCode/pull/341#issuecomment-710177442, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARHJMNN4CTCD7DRIAIQBJYLSLBX5BANCNFSM4SQHXJFQ .
@rishika-singh49 So if you have created a separate code file then you should have committed the changes, push it to the fork and make another PR. Ask doubts if any. Closing this PR.
Can I still update the code
On Fri, Oct 16, 2020, 10:11 PM Pratik Choudhari notifications@github.com wrote:
Closed #341 https://github.com/pratik-choudhari/AlgoCode/pull/341.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pratik-choudhari/AlgoCode/pull/341#event-3887280226, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARHJMNNINFH2DBLIL5IF5NTSLBZU3ANCNFSM4SQHXJFQ .
@rishika-singh49 Yes you can just create another PR when done.
I have tried to do but it gave an error when I requested to push
On Mon, Oct 19, 2020, 5:08 PM Pratik Choudhari notifications@github.com wrote:
@rishika-singh49 https://github.com/rishika-singh49 Yes you can just create another PR when done.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pratik-choudhari/AlgoCode/pull/341#issuecomment-712097994, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARHJMNOIPDVFP6OR2I64ABLSLQQLVANCNFSM4SQHXJFQ .
Oh can you put an SS here?
Description
A comprehensive description about the Pull Request
Reference Issue number #(issue_no)
issue_no
must refer to the issue related to this PR, visit hereType of change
Choosing one or more options from the following as per the nature of your Pull request. NOTE: Check boxes using [x]
Checklist:
Update index.md
)README.md
, with problem description and my name.