search

pratik-choudhari / AlgoCode

Welcome everyone!🌟 Here you can solve problems, build scrappers and much more💻
https://github.com/pratik-choudhari/AlgoCode
MIT License
131 stars 166 forks source link

Inbuilt Sort using STL which is faster than all Sorting Techniques #436

Closed Ankit123848 closed 3 years ago

Ankit123848 commented 3 years ago

Description -> Implemented Inbuilt Sort using standard template library in C++ in sortingMethods -> bool compare function is used which is used as Comparator Function in STL if(a>b)-->it will sort in decreasing order if(a<b)-->it will sort in increasing order -> It is faster than all sorting techniques like bubble sort , insertion sort -> Time Complexity become Optimised -> Comparator function can be used to compare not only numbers but also strings and character array

Reference Issue Number #closed #434

Checklist: I have read the project guidelines. I have checked all the existing projects, before submitting a new project issue. This issue will be meaningful for the project. I will contribute more in future

pratik-choudhari commented 3 years ago

@Ankit123848 mention issue

Ankit123848 commented 3 years ago

This pull request has not associated with any reference issue number...This is a new project that I want to add under sorting folders

On Mon, 19 Oct 2020, 23:36 Pratik Choudhari, notifications@github.com wrote:

@Ankit123848 https://github.com/Ankit123848 mention issue

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pratik-choudhari/AlgoCode/pull/436#issuecomment-712349310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJDAOMUOOMVWDJ2THJQD7LSLR54HANCNFSM4SWGNGRQ .

pratik-choudhari commented 3 years ago

@Ankit123848 So you have not read the code of conduct. It states that you can't contribute just by putting up a PR, that will be labelled invalid. Rather you must create an issue first and get yourself assigned.

Ankit123848 commented 3 years ago

I have read all the instructions and to be honest I am not able to find issue number earlier I have made the changes...Please accept the request

On Mon, 19 Oct 2020, 23:44 Pratik Choudhari, notifications@github.com wrote:

@Ankit123848 https://github.com/Ankit123848 So you have not read the code of conduct. It states that you can't contribute just by putting up a PR, that will be labelled invalid. Rather you must create an issue first and get yourself assigned.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pratik-choudhari/AlgoCode/pull/436#issuecomment-712353941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJDAOKEPVG3MP3RLEVCX7LSLR6XJANCNFSM4SWGNGRQ .

Ankit123848 commented 3 years ago

I am contributing to open source 1st time . Honestly I have searched for issue number but not find it earlier. It would be really great if you remove invalid label otherwise I will not be eligible for hacktoberfest.

On Mon, 19 Oct 2020, 23:49 Ankit Arora, ankitarora772@gmail.com wrote:

I have read all the instructions and to be honest I am not able to find issue number earlier I have made the changes...Please accept the request

On Mon, 19 Oct 2020, 23:44 Pratik Choudhari, notifications@github.com wrote:

@Ankit123848 https://github.com/Ankit123848 So you have not read the code of conduct. It states that you can't contribute just by putting up a PR, that will be labelled invalid. Rather you must create an issue first and get yourself assigned.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pratik-choudhari/AlgoCode/pull/436#issuecomment-712353941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJDAOKEPVG3MP3RLEVCX7LSLR6XJANCNFSM4SWGNGRQ .

pratik-choudhari commented 3 years ago

@Ankit123848 Invalid does not make you ineligible for hacktoberfest. To correct this, go to issues section and put the problem that you have solved in this PR. There I will assigned you and tell you the next steps.