pratik-choudhari / AlgoCode

Welcome everyone!🌟 Here you can solve problems, build scrappers and much more💻

https://github.com/pratik-choudhari/AlgoCode

MIT License

131 stars 166 forks source link

Fenwick trees in C++ #474

Closed cs-mshah closed 3 years ago

cs-mshah commented 3 years ago

Description

Fenwick trees in C++ implemented with README.

Reference Issue number #468

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, with problem description and my name.
[x] My changes do not produce any warnings.

cs-mshah commented 3 years ago

@pratik-choudhari I have made the PR according to the guidelines. Please check and accept the PR. I truly enjoyed contributing to this repository and taking part in the Hacktoberfest. Got to learn a lot!!

pratik-choudhari commented 3 years ago

@cs-mshah Thanks a lot! It was a pleasure having you :)

cs-mshah commented 3 years ago

@pratik-choudhari my PR has been marked ineligible and I don't know why. The repo and the issue both have a hacktoberfest label. A previous PR on this same repo got accepted but this one is invalid.

pratik-choudhari commented 3 years ago

@cs-mshah Oh, that's weird. The repository is still labeled hacktoberfest.

pratik-choudhari commented 3 years ago

i have added another extra label let me know

cs-mshah commented 3 years ago

I don't think anything is possible now. They've labelled it ineligible. They haven't even put any contact so I can tell them.

pratik-choudhari commented 3 years ago

@cs-mshah Ohh, did you make extra PR?