search

pratyaksh1610 / Quiz_App

📱 An Android Quiz App made using Kotlin
19 stars 20 forks source link

Fixed background color for options #16

Closed poseidon2060 closed 2 years ago

poseidon2060 commented 2 years ago

This PR fixes #5

Changes to file:

1)added new xml file in drawable that houses background with color grey for unmarked options 2)while loop to change color of unmarked and marked options

Effect of changes:

1)When clicked on the correct answer all the other options are greyed out and only the correct option is shown with a green view 2)When clicked on the wrong answer the wrong options is displayed in red, correct in green and others are greyed out

Benefits:

Improves readability and avoids confusion

Video demonstrating the change:

https://user-images.githubusercontent.com/101904141/193474530-1a4326dc-95bf-4617-b072-92c9f5019415.mp4

poseidon2060 commented 2 years ago

@pratyaksh1610 I created this new pull request as I accidentally closed the previous one, I have fixed all errors and conflicts I apologize for the trouble since this is my first PR. Let me know if anything else needs to be done for this

poseidon2060 commented 2 years ago

@pratyaksh1610 What is the difference between pull request being "approved" and it being merged? Is my PR merged right now?

pratyaksh1610 commented 2 years ago

LGTM , Thanks !