Closed pratyushtiwary closed 1 year ago
Hello, can I be assigned this task? I'm planing to use this library for the module https://github.com/soldair/node-qrcode Let me know if you have any further suggestions or comments :)
I have the PR ready to roll, but I was wondering... can we wait until October to make it count on the hacktoberfest, please?
Sure. Until then maybe document the code so that when you submit the PR it'll be easy for me to go through it.
Also extremely sorry for closing the issue. I, by mistake, pressed Close with comment rather than comment. This will not happen again.
Absolutely, I'll start documenting the code using JSDoc format :)
Here's an overview of the new module's appearance:
Additionally, you can upload a QR code to extract text from it:
When no QR code is detected in the uploaded image, we display an error message like this:
Lastly, we offer a variety of QR templates:
Please let me know if this feature covers all the required functionality for this new module
This looks amazing! Well done @josediego
You've covered all the functionalities that I expected, thank you so much for the amazing work.
Also I've gone through your code and it looks good the only thing that bothers me is watchEffect
usage, if possible then please don't use watchEffect
, it makes the module slow.
Thanks for the suggestion @pratyushtiwary
I removed the dependency of watchEffect
and it works fine now :) check this out https://github.com/josediego/devty/commit/8090ceea188044e71f725eadf25d417ccff2c488
Great work!
The requested module will be able to generate and read QR codes. Reference: https://devutils.com/demo/#qrcode