prave1n / pe

0 stars 0 forks source link

DelAppt command's parameter requirements are unclear #3

Open prave1n opened 1 week ago

prave1n commented 1 week ago

Steps to replicate:

Screenshot 2024-11-15 at 4.47.14 PM.png

Expected output: Both appointments added would be deleted.

Actual output: Error message that "There is no appointment with the given date and time period for this person!"

This behaviour, while it may be intended could be more clearly expressed in the UG

Screenshot 2024-11-15 at 4.49.03 PM.png

In the UG, there is no mention that the date and time must be an exact match. The user may believe that the command can be used to remove any appointments for the person within the given range of APPOINTMENT_TIME.

This can lead to confusion in the user who may be falsely believe that no their appointments were not added properly.

nus-pe-bot commented 1 week ago

Team's Response

In our User Guide, we mentioned that the delAppt command is used to delete a single appointment and not multiple appointments. Hence, the feature is working as intended based on the given example.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: I understand that the UG has used singular terms like 'a' and 'and' to indicate that only one appointment will be deleted. However, that does not change the fact that it has not been documented in the UG that exact date and time of the appointment must be given for an appointment to be deleted.

For example, if the user ran the following commands:

just like i had mentioned in the initial bug report, the user may believe that the command can be used to remove an appointment for the person as long as the appointment falls within the given range of APPOINTMENT_TIME. In the above example the appointment which is from 1100 - 1200 falls within the 1000-1500 input in the delAppt command