prave1n / pe

0 stars 0 forks source link

Application allows for adding appointments with invalid dates #6

Open prave1n opened 1 week ago

prave1n commented 1 week ago

Steps to replicate:

Screenshot 2024-11-15 at 5.19.21 PM.png

expected output: error message since appointment date is before birth date of patient

actual output: successfully adds the appointment

this is an invalid input for the date as it should not be possible to add an appointment for the patient even before their birth date

nus-pe-script commented 1 week ago

Team's Response

Thank you for your feedback.

We allowed this behaviour for two main reasons:

  1. Preventing overzealous input allows for users to set arbitrary dates to indicate any specialised meanings (e.g. unconfirmed date) and we give users the trust and freedom to choose what they wish to do with the input of possibly unrealistic but valid dates.

  2. We trust users are vigilant enough to input and recheck the inputted date. Typos in date input will not be addressed properly by just limiting the dates to after the birth date as incorrectly inputting dates can still pass this check if after the birth date.

As such, it might not be in scope for fixing as it does not affect normal usage of the application, and might even be detrimental to fix for our users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]