search

praveenscience / Internship-LMS-FrontEnd

We are in the mission of solving a crisis for a lot of small and medium enterprises, who are trying to recruit interns for their projects. This platform aims to onboard new interns, who have applied to the companies and help them understand the process and make the transition smooth.
GNU General Public License v3.0
357 stars 183 forks source link

Integrate Netlify for Deploy Previews #20

Open praveenscience opened 3 years ago

praveenscience commented 3 years ago

As we move up to the coding phase now, let's start implementing the Deploy Previews feature of Netlify. When someone creates a PR, the netlify service should send a link to show how it looks.

You can find more information here: Introducing Deploy Previews in Netlify. This is up for grabs people. Anyone from DWoC or SWoC can pick it up.

When you pick up, please answer the following in bullet points as answers:

As always, reach out to me in case of anything. 😁

avinashupadhya99 commented 3 years ago

Hi, can I work on this?

Do you understand what is required? Do you need any help with the issue?

Yes, it is essentialy setting up a CICD for the application

How much Netlify integration knowledge you have? You wanna try or you know it and you wanna work?

I haven't done much with Netlify but I have worked with other hosting services. I want to learn doing it on Netlify and will do so.

Which programme you're working on? DWoC or SWoC or both?

I am working on DWoC

Can you please assign this to me?

praveenscience commented 3 years ago

Hi @avinashupadhya99, yes, technically it's setting up CI/CD for only the PRs... 😁

Can you please assign this to me?

Cool, you can start working on this. 😁 Keep me updated with the progress.

avinashupadhya99 commented 3 years ago

Hey, I looked up deploy previews on Netlify and tested it out with my repo. There are no code changes necessary for deploy previews. Once the repository is set up for deployment on Netlify, any PR made to the repository will have a deploy preview. There are no changes required.

Please let me know if you plan on implementing CICD for the entire application. I can work on that. 🥂

praveenscience commented 3 years ago

Yes, @avinashupadhya99. What needs to be done? Should we do it together?

Just saw this: You only need to add commit hooks to your Netlify sites, we take care of the rest.

praveenscience commented 3 years ago

@avinashupadhya99 I'll set this thing up. Once I have done it, I'll ask you to update some code changes so that you get the points for looking into. Hope that helps?

avinashupadhya99 commented 3 years ago

You only need to add commit hooks to your Netlify sites, we take care of the rest.

Yes you just need to add the repository on Netlify. Everything else is taken care by them.

@avinashupadhya99 I'll set this thing up. Once I have done it, I'll ask you to update some code changes so that you get the points for looking into. Hope that helps?

No issue. I will work on other issues that come up

praveenscience commented 3 years ago

@avinashupadhya99 This one is still your responsibility. Thanks for getting me a clarity on this. 😁 Will award the right points for you.

avinashupadhya99 commented 3 years ago

I'm sorry, I didn't get it. Should I set up the netlify on my account? If yes, I don't think that is possible because I would need access to the repository.

If it is regarding the points for DWoC, I'm fine with it. 😄 I got to learn something new. 😁

praveenscience commented 3 years ago

@avinashupadhya99 Send a random PR to fix something. I'll get you the points you deserve. Can you please do it now?

Uyadav207 commented 3 years ago

@praveenscience and @avinashupadhya99 , i have worked with netlify CI, i might help you both. infact my all website are netlify deployed.

praveenscience commented 3 years ago

@Uyadav207 Sure, let's jump on a call.

praveenscience commented 3 years ago

@satyampandeygit Did you message something here?

ampsteric commented 3 years ago

@praveenscience as it is the admin who needs to link his repo to his own netlify credentials, should I close this issue?

praveenscience commented 3 years ago

@ampsteric Once I do it, let's close it. I'll self-assign it to myself.

subhangi2731 commented 3 years ago

please assign this to me

praveenscience commented 3 years ago

@subhangi2731 I have assigned it to you.

gargijs commented 3 years ago

I want to work on this

Abhishekkr93 commented 3 years ago

I want to fix this, please assign me.

praveenscience commented 3 years ago

Let's meet on Monday to check the status of this:

Abhishekkr93 commented 3 years ago

Okay sir. @praveenscience

subhangi2731 commented 3 years ago

@praveenscience I will make a pr by today

subhangi2731 commented 3 years ago

Sorry I had exams in my college @praveenscience

praveenscience commented 3 years ago

Okay thanks, let me know the progress folks! 🔥

praveenscience commented 3 years ago

Any updates folks? By tomorrow, if there's no activity, I am happy to do it myself and implement this... 🔥

praveenscience commented 3 years ago

We're taking this on Live Stream and making it work! 🔥 Thanks everyone for all your efforts. 😊 Please let's meet on the Live Stream to know how this is done. 👍

praveenscience commented 3 years ago

@subhangi2731 Since you messaged me, would you like to collaborate with me on the Live?

vave4 commented 3 years ago

Can I try solving this issue?

praveenscience commented 3 years ago

Yes, sure @vave4

praveenscience commented 3 years ago

Any updates @vave4?