search

praveenscience / Internship-LMS-FrontEnd

We are in the mission of solving a crisis for a lot of small and medium enterprises, who are trying to recruit interns for their projects. This platform aims to onboard new interns, who have applied to the companies and help them understand the process and make the transition smooth.
GNU General Public License v3.0
357 stars 183 forks source link

Enforce Prettier on commits and builds. #36

Closed praveenscience closed 3 years ago

praveenscience commented 3 years ago

I have got this prettier options configured in VS Code. We need a way to ensure that this is there in the build times. If it's not used, including the spaces, etc., the build should fail.

{
  "arrowParens": "avoid",
  "bracketSpacing": true,
  "endOfLine": "lf",
  "htmlWhitespaceSensitivity": "css",
  "insertPragma": false,
  "jsxBracketSameLine": false,
  "jsxSingleQuote": false,
  "printWidth": 80,
  "proseWrap": "preserve",
  "quoteProps": "as-needed",
  "requirePragma": false,
  "semi": true,
  "singleQuote": false,
  "tabWidth": 2,
  "trailingComma": "none",
  "useTabs": false,
  "vueIndentScriptAndStyle": false,
  "filepath": "Untitled-1",
  "parser": "babel"
}

This issue is up for grabs for both DWoC and SWoC.

sonaliBedade commented 3 years ago

I am a participant of SWoC and I will like to work on this issue. I use both VS Code and Prettier extension and I am familiar with it. Please assign this issue to me so that I can start working on it.

Sloth-Panda commented 3 years ago

@praveenscience sir, can you explain a bit how can we do the same?

praveenscience commented 3 years ago

@Sloth-Panda Something like this: https://gist.github.com/jareware/7179093

praveenscience commented 3 years ago

@Sloth-Panda and @sonaliBedade Check these out:

I guess these might be a good start...

dollyjain51099 commented 3 years ago

I would like to work on this issue, @praveenscience kindly assign it to me!

praveenscience commented 3 years ago

Hey @dollyjain51099, sure... You can also discuss with @sonaliBedade, as you both know each other! 😅

sahildotexe commented 3 years ago

Hey !! I 'm a participant of GSSOC'21, can you assign this issue to me?

praveenscience commented 3 years ago

@sahildotexe It's already being done by @dollyjain51099 and @sonaliBedade... Check if there are issues that are not claimed. Also check with them, they're struggling on bringing this to CI CD.

ampsteric commented 3 years ago

@praveenscience should this issue be closed as you mentioned that we are planning to use something like husky.

praveenscience commented 3 years ago

@ampsteric This is totally different. This is for the CI CD Pipeline.

ampsteric commented 3 years ago

Ohh okay , actually I saw your comment https://github.com/praveenscience/Internship-LMS-FrontEnd/pull/41#pullrequestreview-610188866 and thought of asking.