Rename .env from the Codebase

praveenscience / easya-website

This is the source code for EasyA Website built for Enterprise entirely using React JS.

https://easya.jigg.win/

GNU General Public License v3.0

24 stars 35 forks source link

Closed jainaayush01 closed 3 years ago

jainaayush01 commented 3 years ago

I think it is of no use but still, it is not a good practice to keep an .env file in the codebase

praveenscience commented 3 years ago

Maybe can you just make it from .env to .env.sample? What say? For new people. And also add .env to the .gitignore file.

jainaayush01 commented 3 years ago

Yeah sure that would be a nice idea. Changes: rename .env to .env.sample add it to gitignore

am I correct?

praveenscience commented 3 years ago

Yes, you wanna do it or give another person a chance? Your wish!

jainaayush01 commented 3 years ago

.env.sample will look like:

REACT_APP_LANG=

i did it already maybe in next one

praveenscience commented 3 years ago

I am gonna kill you! 🤣 It should be English! 🤦🏻‍♂️

praveenscience commented 3 years ago

@jainaayush01 Go for it...

But check with the code, if English is what we're using.

jainaayush01 commented 3 years ago

I am gonna kill you! 🤣 It should be English! 🤦🏻‍♂️

I thought the same but In the codebase, I saw the name of the contributor nikhar. so I thought that the variable is storing the name of the person.

Changing it now.