pravega / flink-connectors

Apache Flink connectors for Pravega.
Apache License 2.0
96 stars 66 forks source link

[Issue-685] Change deprecated usage of `DeleteScope` API #688

Closed fyang86 closed 2 years ago

fyang86 commented 2 years ago

Signed-off-by: Fan, Yang fan.yang5@emc.com

Change log description Change the usage of deprecated deleteScope() API to a new deleteScopeRecursive() API as introduced in Pravega 0.11.0(ref: https://github.com/pravega/pravega/pull/6312).

Purpose of the change Fix #685

What the code does Change deleteScope() to deleteScopeRecursive() in PravegaCatalog

How to verify it ./gradlew clean build should pass

codecov[bot] commented 2 years ago

Codecov Report

Merging #688 (f2c2eba) into master (b4b0015) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #688      +/-   ##
============================================
- Coverage     81.01%   80.97%   -0.04%     
- Complexity      568      569       +1     
============================================
  Files            60       60              
  Lines          2712     2712              
  Branches        234      234              
============================================
- Hits           2197     2196       -1     
- Misses          326      328       +2     
+ Partials        189      188       -1     
Impacted Files Coverage Δ
...rs/flink/table/catalog/pravega/PravegaCatalog.java 68.09% <100.00%> (ø)
...link/source/enumerator/PravegaSplitEnumerator.java 78.31% <0.00%> (-3.62%) :arrow_down:
...vega/connectors/flink/sink/PravegaEventWriter.java 68.91% <0.00%> (+2.70%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4b0015...f2c2eba. Read the comment docs.