search

pravega / flink-connectors

Apache Flink connectors for Pravega.
Apache License 2.0
96 stars 67 forks source link

[Issue-704] Reduce TableSchema usages #707

Closed fyang86 closed 1 year ago

fyang86 commented 1 year ago

Signed-off-by: Fan, Yang fan.yang5@emc.com

Change log description Remove the deprecated TableSchema class in Table API connectors.

NOTE: We will keep the TableSchema usage in PravegaCatalog because currently we are using TableSchema to get Schema Registry's SchemaInfo when we create a catalog table and there's no alternative approach to replace this uasge as for now.

Purpose of the change Fix #704

What the code does

How to verify it ./gradlew clean build should pass

codecov[bot] commented 1 year ago

Codecov Report

Base: 80.94% // Head: 80.84% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (fb41c39) compared to base (65c1a09). Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #707 +/- ## ============================================ - Coverage 80.94% 80.84% -0.10% + Complexity 570 569 -1 ============================================ Files 62 62 Lines 2702 2704 +2 Branches 233 233 ============================================ - Hits 2187 2186 -1 - Misses 326 328 +2 - Partials 189 190 +1 ``` | [Impacted Files](https://codecov.io/gh/pravega/flink-connectors/pull/707?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [...nk/dynamic/table/FlinkPravegaDynamicTableSink.java](https://codecov.io/gh/pravega/flink-connectors/pull/707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-c3JjL21haW4vamF2YS9pby9wcmF2ZWdhL2Nvbm5lY3RvcnMvZmxpbmsvZHluYW1pYy90YWJsZS9GbGlua1ByYXZlZ2FEeW5hbWljVGFibGVTaW5rLmphdmE=) | `64.58% <90.00%> (+0.75%)` | :arrow_up: | | [...dynamic/table/FlinkPravegaDynamicTableFactory.java](https://codecov.io/gh/pravega/flink-connectors/pull/707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-c3JjL21haW4vamF2YS9pby9wcmF2ZWdhL2Nvbm5lY3RvcnMvZmxpbmsvZHluYW1pYy90YWJsZS9GbGlua1ByYXZlZ2FEeW5hbWljVGFibGVGYWN0b3J5LmphdmE=) | `100.00% <100.00%> (ø)` | | | [...rs/flink/table/catalog/pravega/PravegaCatalog.java](https://codecov.io/gh/pravega/flink-connectors/pull/707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-c3JjL21haW4vamF2YS9pby9wcmF2ZWdhL2Nvbm5lY3RvcnMvZmxpbmsvdGFibGUvY2F0YWxvZy9wcmF2ZWdhL1ByYXZlZ2FDYXRhbG9nLmphdmE=) | `68.29% <100.00%> (+0.19%)` | :arrow_up: | | [...ravega/connectors/flink/sink/PravegaCommitter.java](https://codecov.io/gh/pravega/flink-connectors/pull/707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-c3JjL21haW4vamF2YS9pby9wcmF2ZWdhL2Nvbm5lY3RvcnMvZmxpbmsvc2luay9QcmF2ZWdhQ29tbWl0dGVyLmphdmE=) | `65.21% <0.00%> (-6.53%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.