search

pravega / flink-connectors

Apache Flink connectors for Pravega.
Apache License 2.0
96 stars 66 forks source link

Use `DeliveryGuarantee` enum as sink configuration #709

Closed fyang86 closed 1 year ago

fyang86 commented 1 year ago

Problem description Flink has already provided a enum DeliveryGuarantee to describe the delivery guarantee that our sink uses. We should leverage it instead of the current PravegaWriterMode enum.

Problem location PravegaWriterMode, Sink

Suggestions for an improvement

crazyzhou commented 1 year ago

For this task, we need to mark the writer mode API deprecated, and keep its compatibility for this release for now. We will consider removing the writer mode in the next one or two releases.

crazyzhou commented 1 year ago

As the new Sink API is still marked experimental, we decide not changing the old Sink API to keep the compatibility, and directly change to use the DeliveryGuarantee and remove the writer mode support in the new Sink API.