search

pravega / pravega-benchmark

Performance benchmark tool for Pravega
Apache License 2.0
8 stars 22 forks source link

Issue 57 & 60: Add "-fork " and "-kafka" options #61

Open kmgowda opened 5 years ago

kmgowda commented 5 years ago

Change log description
A new option "-fork" option is added; by default it is set to True; if it is set to false, then new fixed thread pool is used. Another new option "-kafka" is added; by default it is set to False; it it is set to true, then kafka bench-marking is conducted.

Purpose of the change
Fixes #57 , #60

What the code does
when user supplies -fork false; conventional thread pool is used; otherwise fork join pool is used. when user supplied -kafka true; the kafka bench-marking is conducted.

Signed-off-by: Keshava Munegowda keshava.munegowda@dell.com

maddisondavid commented 4 years ago

Are the two options -fork and -kafka related? On an initial pass of the code it looks like this could be better handled (and digested) as two different PRs

kmgowda commented 4 years ago

@maddisondavid yes, it could be handled as two separate PRs..but, since, I was moved out of the team and i was busy in taking up other activities; before i left, I just combined my pending work into single PR.